Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3-plain based disk supporting directory rename #61116

Merged
merged 22 commits into from
Apr 30, 2024

Conversation

jkartseva
Copy link
Contributor

@jkartseva jkartseva commented Mar 9, 2024

Fixes: #58347

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added a rewritable S3 disk which supports INSERT operations and does not require locally stored metadata.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-feature Pull request with new product feature label Mar 9, 2024
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Mar 9, 2024

This is an automated comment for commit dc95558 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@jkartseva jkartseva marked this pull request as draft March 9, 2024 06:38
@kssenii kssenii self-assigned this Mar 9, 2024
@jkartseva jkartseva force-pushed the s3-plain-with-replace branch 3 times, most recently from e13a6b4 to b740637 Compare March 14, 2024 03:35
@jkartseva jkartseva added the can be tested Allows running workflows for external contributors label Mar 14, 2024
@jkartseva jkartseva force-pushed the s3-plain-with-replace branch 14 times, most recently from e198384 to 84c645b Compare March 20, 2024 22:05
@jkartseva jkartseva force-pushed the s3-plain-with-replace branch 7 times, most recently from 7d6a514 to 8e45f6f Compare March 28, 2024 04:29
Comment on lines 366 to 367
/// Whether this disk support mutations.
virtual bool isMutable() const { return true; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be better to explicitly name it supportsHardlinks? Because isMutable is kind of the opposite of IDisk::isReadOnly, so might be confusing


drop table if exists test_mt;
create table test_mt (a Int32, b Int64) engine = MergeTree() order by a
settings disk = disk(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_log system tables defined for CI are in ClickHouse/tests/config/config.d/, for example, https://github.com/ClickHouse/ClickHouse/blob/master/tests/config/config.d/blob_storage_log.xml. It is possible to define engine parameter in this config, where we can also add storage_policy, example:

<engine>Engine = MergeTree PARTITION BY event_date ORDER BY event_time TTL event_date + INTERVAL 30 day SETTINGS storage_policy='policy2', ttl_only_drop_parts=1</engine>

We could add s3_plain_rewritable for blob_storage_log from the example above. Possibly it will be better to do this only for a tests run which runs all tests on top of s3, this can be checked here
if [[ "$USE_S3_STORAGE_FOR_MERGE_TREE" == "1" ]]; then
. E.g. in this if branch we could substitute blob_storage_log.xml to a different one (with a different storage policy) instead of what is added here
ln -sf $SRC_PATH/config.d/blob_storage_log.xml $DEST_SERVER_PATH/config.d/

jkartseva and others added 22 commits April 29, 2024 18:01
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
…Operations.cpp

Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
non-functional changes
Make PlainRewritableObjectStorage generic;

Support config type
```
<s3_plain_rewritable>
    <type>object_storage</type>
    <object_storage_type>s3</object_storage_type>
    <metadata_type>plain_rewritable</metadata_type>
    <endpoint>https://s3.eu-west-1.amazonaws.com/clickhouse-eu-west-1.clickhouse.com/data/</endpoint>
    <use_environment_credentials>1</use_environment_credentials>
</s3_plain_rewritable>
```
@jkartseva
Copy link
Contributor Author

Getting an error when trying to specify <engine>Engine = MergeTree PARTITION BY ... </engine>

2024.04.30 08:11:13.067385 [ 771 ] {} <Error> Application: Caught exception while loading metadata: Code: 36. DB::Exception: If 'engine' is specified for system table, PARTITION BY parameters should be specified directly inside 'engine' and 'partition_by' setting doesn't make sense. (BAD_ARGUMENTS), Stack trace (when copying this message, always include the lines below):

I'll remove the commit with blog_storage_log config from the stack and follow-up separately.

@alexey-milovidov alexey-milovidov merged commit 90d8e3c into ClickHouse:master Apr 30, 2024
208 of 221 checks passed
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 30, 2024
@jkartseva jkartseva deleted the s3-plain-with-replace branch May 3, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A disk similar to s3_plain that allows directory rename.
5 participants