Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit backtracking in parser #61502

Merged
merged 5 commits into from
Mar 17, 2024
Merged

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add a new setting max_parser_backtracks which allows to limit the complexity of query parsing.

@robot-ch-test-poll robot-ch-test-poll added the pr-improvement Pull request with some product improvements label Mar 17, 2024
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Mar 17, 2024

This is an automated comment for commit 95cfba9 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov alexey-milovidov self-assigned this Mar 17, 2024
@alexey-milovidov alexey-milovidov merged commit 3098cd2 into master Mar 17, 2024
192 of 204 checks passed
@alexey-milovidov alexey-milovidov deleted the limit-backtracking-in-parser branch March 17, 2024 22:55
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 17, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Mar 18, 2024
(cherry picked from commit e015f2a8eb8e86cfd1f691ffa85dd732c9b2f77f)
baibaichen added a commit to Kyligence/gluten that referenced this pull request Mar 18, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Mar 19, 2024
baibaichen added a commit to apache/incubator-gluten that referenced this pull request Mar 19, 2024
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240319)

1 fix build due to ClickHouse/ClickHouse#61502
2 fix build due to ClickHouse/ClickHouse#61114
3 fix build due to ClickHouse/ClickHouse#61267

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
baibaichen added a commit to baibaichen/gluten that referenced this pull request Mar 19, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Mar 19, 2024
baibaichen added a commit to apache/incubator-gluten that referenced this pull request Mar 20, 2024
* Fix typo

(cherry picked from commit c3fbf13)

* 1. using FutureSetFromTuple instead of FutureSetFromStorage. FutureSetFromTuple can buildOrderedSetInplace automatocally, FutureSetFromStorage need set Sizelimits mannually

2. Support PageIndex,  set spark.gluten.sql.columnar.backend.ch.runtime_config.use_local_format to true again.

3. Remove skipped test

* refactor gtest

* fix build due to #4664

* v2 for finding performance issue

* Refactor:
add ParquetFileReaderExtBase
add readColumnChunkPageBase
simpilefy build read
remove redundant codes
reemove current_row_group_
std::vector<int32_t> row_groups_ => std::deque<int32_t> row_groups_
std::vector<std::unique_ptr<RowRanges>> row_group_row_ranges_ => std::unordered_map<int32_t, std::unique_ptr<RowRanges>> row_group_row_ranges_
std::vector<std::unique_ptr<ColumnIndexStore>> row_group_column_index_stores_ => std::unordered_map<int32_t, std::unique_ptr<ColumnIndexStore>> row_group_column_index_stores_;
remove std::vector<std::unique_ptr<parquet::RowGroupMetaData>> row_group_metas_;
remove std::vector<std::shared_ptr<parquet::RowGroupPageIndexReader>> row_group_index_readers_

* new loop

* Cleanup

* Cleanup

* Revert: fix build due to #4664

* support case_insensitive_column_matching of parquet

(cherry picked from commit bce0c6668d7bb397127eefeac1943d4c02cf79dc)

* fix case_insensitive_column_matching issue
fix a stupid bug!
add testDataPath
getTpcdsDataPath() => tpcdsDataPath
getClickHouseLibPath() => clickHouseLibPath

* add benchmark

(cherry picked from commit bb0267135243ff8ad980b0521d8302e150a2c4e4)

* lowercase first letter of function name

(cherry picked from commit 98dc9a79bf4f372ecabcac9b47aa06cd328f1aa4)

* add comments

(cherry picked from commit 2fb41831f4e338503ff620ce5eac9917bdb68f6a)

* Remove Camel case member variable

(cherry picked from commit 1ace73205a033e14ca1659f063eb1df65c3e9969)

* Use Int32 instead of int32_t

(cherry picked from commit e7d8fbe701fcd92fb6cb167686602561adc26ec4)

* Camel case for function name

(cherry picked from commit 1ee0516e2eadf045b4aec63de67cf5cb97810217)

* add ColumnIndexFilterPtr alias

(cherry picked from commit 1e9cdd3b08eb4e026a739ee558e9c2dd0c4c88fb)

* using RowRangesMap = absl::flat_hash_map<Int32, std::unique_ptr<RowRanges>>;
using ColumnIndexStoreMap = absl::flat_hash_map<Int32, std::unique_ptr<ColumnIndexStore>>;

(cherry picked from commit 610fcd038d24d54fa30bcc40ab0d4d39f60dd0c4)

* fix style

(cherry picked from commit 8d85db48fe1c93dbc05404aa580b3f11de94c51d)

* fix benchmark due to #4995

* fix build due to ClickHouse/ClickHouse#61502

* fix assertion failed in Debug Build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants