-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit backtracking in parser #61502
Merged
Merged
Limit backtracking in parser #61502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-improvement
Pull request with some product improvements
label
Mar 17, 2024
Contributor
This is an automated comment for commit 95cfba9 with description of existing statuses. It's updated for the latest CI running ⏳ Click here to open a full report in a separate page
Successful checks
|
robot-clickhouse-ci-2
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Mar 17, 2024
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Mar 18, 2024
(cherry picked from commit e015f2a8eb8e86cfd1f691ffa85dd732c9b2f77f)
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Mar 18, 2024
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Mar 19, 2024
(cherry picked from commit 1c6605e)
baibaichen
added a commit
to apache/incubator-gluten
that referenced
this pull request
Mar 19, 2024
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240319) 1 fix build due to ClickHouse/ClickHouse#61502 2 fix build due to ClickHouse/ClickHouse#61114 3 fix build due to ClickHouse/ClickHouse#61267 --------- Co-authored-by: kyligence-git <gluten@kyligence.io> Co-authored-by: Chang Chen <baibaichen@gmail.com>
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Mar 19, 2024
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Mar 19, 2024
baibaichen
added a commit
to apache/incubator-gluten
that referenced
this pull request
Mar 20, 2024
* Fix typo (cherry picked from commit c3fbf13) * 1. using FutureSetFromTuple instead of FutureSetFromStorage. FutureSetFromTuple can buildOrderedSetInplace automatocally, FutureSetFromStorage need set Sizelimits mannually 2. Support PageIndex, set spark.gluten.sql.columnar.backend.ch.runtime_config.use_local_format to true again. 3. Remove skipped test * refactor gtest * fix build due to #4664 * v2 for finding performance issue * Refactor: add ParquetFileReaderExtBase add readColumnChunkPageBase simpilefy build read remove redundant codes reemove current_row_group_ std::vector<int32_t> row_groups_ => std::deque<int32_t> row_groups_ std::vector<std::unique_ptr<RowRanges>> row_group_row_ranges_ => std::unordered_map<int32_t, std::unique_ptr<RowRanges>> row_group_row_ranges_ std::vector<std::unique_ptr<ColumnIndexStore>> row_group_column_index_stores_ => std::unordered_map<int32_t, std::unique_ptr<ColumnIndexStore>> row_group_column_index_stores_; remove std::vector<std::unique_ptr<parquet::RowGroupMetaData>> row_group_metas_; remove std::vector<std::shared_ptr<parquet::RowGroupPageIndexReader>> row_group_index_readers_ * new loop * Cleanup * Cleanup * Revert: fix build due to #4664 * support case_insensitive_column_matching of parquet (cherry picked from commit bce0c6668d7bb397127eefeac1943d4c02cf79dc) * fix case_insensitive_column_matching issue fix a stupid bug! add testDataPath getTpcdsDataPath() => tpcdsDataPath getClickHouseLibPath() => clickHouseLibPath * add benchmark (cherry picked from commit bb0267135243ff8ad980b0521d8302e150a2c4e4) * lowercase first letter of function name (cherry picked from commit 98dc9a79bf4f372ecabcac9b47aa06cd328f1aa4) * add comments (cherry picked from commit 2fb41831f4e338503ff620ce5eac9917bdb68f6a) * Remove Camel case member variable (cherry picked from commit 1ace73205a033e14ca1659f063eb1df65c3e9969) * Use Int32 instead of int32_t (cherry picked from commit e7d8fbe701fcd92fb6cb167686602561adc26ec4) * Camel case for function name (cherry picked from commit 1ee0516e2eadf045b4aec63de67cf5cb97810217) * add ColumnIndexFilterPtr alias (cherry picked from commit 1e9cdd3b08eb4e026a739ee558e9c2dd0c4c88fb) * using RowRangesMap = absl::flat_hash_map<Int32, std::unique_ptr<RowRanges>>; using ColumnIndexStoreMap = absl::flat_hash_map<Int32, std::unique_ptr<ColumnIndexStore>>; (cherry picked from commit 610fcd038d24d54fa30bcc40ab0d4d39f60dd0c4) * fix style (cherry picked from commit 8d85db48fe1c93dbc05404aa580b3f11de94c51d) * fix benchmark due to #4995 * fix build due to ClickHouse/ClickHouse#61502 * fix assertion failed in Debug Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-improvement
Pull request with some product improvements
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add a new setting
max_parser_backtracks
which allows to limit the complexity of query parsing.