Fix PartsSplitter

[nickitat]

Changelog category (leave one):

• Bug Fix

Changelog entry:

When some index columns are not loaded into memory for some parts of a *MergeTree table, queries with FINAL might produce wrong results. Now we explicitly choose only the common prefix of index columns for all parts to avoid this issue.

---

Related: #62173 #62192 #62252

cc @nikitamikhaylov @jkartseva

[robot-ch-test-poll3]

This is an automated comment for commit 378d330 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	❌ failure
Bugfix validation	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	❌ failure
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	❌ failure
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	❌ failure

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

[nickitat]

apparently problem is coming from recent optimisation of not loading some index columns. splitting on layers was incorrect, for one part instead of range (0, 4) we took only (0, 2). I noticed that for it we use only first column value as the index value, while the index consists of 3 columns. then I set primary_key_ratio_of_unique_prefix_values_to_skip_suffix_columns=1 and it fixed the test.

[clickhouse-ci]

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Changelog entry required for category 'Bug Fix'

[alexey-milovidov]

This could be a functional test.

[nikitamikhaylov]

But the test restarts ClickHouse server.

[nickitat]

yep, I'm not aware of a way to trigger index optimisation w/o server restart

[alexey-milovidov]

DETACH/ATTACH a table.

[alexey-milovidov]

.

[nickitat]

as some of us already noticed, 00147_global_in_aggregate_function failed in CI with this fix.

https://s3.amazonaws.com/clickhouse-test-reports/62268/378d330d9dfa289c413f80c2addaf6dee5503093/stateful_tests__tsan_.html

though it seems there is a different issue, because this test fails almost in 100% cases with the following settings:

set merge_tree_read_split_ranges_into_intersecting_and_non_intersecting_injection_probability=0,
allow_prefetched_read_pool_for_remote_filesystem=0,
max_block_size=69749, max_threads=32;

yep, it is analyzer.

#62451