-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fmtlib version to 9.1.0 #64959
Conversation
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Please do not skip tests when you are doing global changes |
This is an automated comment for commit 857a412 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why you decided to update to 9.1 and not the latest (10.2)?
@Algunenano I tried 10.2 first, but then found that there's too many compile errors. The main reason is fmt has a break chance since v10.0:
We need to figure out where are implicit conversions in ClickHouse and fix it. Let see if I can do it quick. |
@Algunenano done for almost types, except the new
|
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
The only workaround I could find is an ugly rewrite of Not sure if there are better options. |
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
0d8bd13
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Primary motivation is to add Ceph as submodule (#62821), but I think it's nice to have in general (e.g.
fmt::ostream_formatter
).Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):