-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented connecting to ClickHouse server over TLS #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using OpenSSL - set `-DWITH_OPENSSL:BOOL=ON` to enable - can use non-system OpenSSL with `-DOPENSSL_ROOT_DIR=<path-to-OpenSSL>` - Client behavior is customizable with `ClientOptions::SSLOptions` - min/max protocol versions - SNI extension ON\OFF - CA files or directory - other tweaks available via `SSL_CTX_set_options` - OR provide pre-configured `SSL_CTX` with any customizations. Tests to verify TLS connection to an external host. Tests to verify TLS connection to locally started CH.
traceon
requested changes
Nov 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
Enmk
force-pushed
the
openssl
branch
2 times, most recently
from
November 8, 2021 19:53
3a68389
to
e06893b
Compare
traceon
requested changes
Nov 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left inline comments.
minor renaming, comments and other grooming
traceon
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using OpenSSL
-DWITH_OPENSSL:BOOL=ON
to enable-DOPENSSL_ROOT_DIR=<path-to-OpenSSL>
Client behavior is customizable with
ClientOptions::SSLOptions
SSL_CTX_set_options
SSL_CTX
with any customizations.Tests to verify TLS connection to an external host.
Tests to verify TLS connection to locally started CH with custom CA (CA and certificate files not included)