Fix build on clang & libc++ #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you please sign the CLA? |
Enmk
reviewed
Apr 13, 2022
| BUILDING_WITH_LIB_STDCXX) | ||
|
|
||
| IF (BUILDING_WITH_LIB_STDCXX) | ||
| # there is a problem with __builtin_mul_overflow call at link time |
There was a problem hiding this comment.
Just a wild idea: maybe check if compilation fails when __builtin_mul_overflow is used?
There was a problem hiding this comment.
Yeah it crossed my mind, but what about the other workarounds within the same IF () block ?
# some workaround for linking issues on linux:
# /usr/bin/ld: CMakeFiles/simple-test.dir/main.cpp.o: undefined reference to symbol '_Unwind_Resume@@GCC_3.0'
# /usr/bin/ld: /lib/x86_64-linux-gnu/libgcc_s.so.1: error adding symbols: DSO missing from command line
# FIXME: that workaround breaks clang build on mingw
TARGET_LINK_LIBRARIES (clickhouse-cpp-lib gcc_s)
TARGET_LINK_LIBRARIES (clickhouse-cpp-lib-static gcc_s)
Should I move these into a dedicated IF () / ENDIF () block with a condition on simple-test.dir/main.cpp compilation ?
Do not link with gcc & libstdc++ support libraries when going with clang & libc++. Signed-off-by: David Keller <david@woorton.com>
DavidKeller
force-pushed
the
feature/clang-and-libc++
branch
from
9b6aa3d to
1db88fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not link with gcc & libstdc++ support libraries when going with clang & libc++.
Signed-off-by: David Keller david@woorton.com