Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test refactoring #179

Merged
merged 8 commits into from
May 16, 2022
Merged

Test refactoring #179

merged 8 commits into from
May 16, 2022

Conversation

Enmk
Copy link
Collaborator

@Enmk Enmk commented May 12, 2022 •
edited
Loading

  • Added a set of generic tests that validate general API for Column subclass, see ut/Column_ut.cpp
  • moved tests around to simplify ut/columns_ut.cpp
  • moved utility code around to simplify ut/utils.h
  • fixed bug in ColumnDateTime::CloneEmpty

@Enmk Enmk mentioned this pull request May 12, 2022
Merged
@Enmk Enmk closed this May 12, 2022
@Enmk Enmk reopened this May 12, 2022
@Enmk Enmk force-pushed the test_refactoring branch from a0302d5 to fa9a93a Compare May 16, 2022 08:07
@Enmk Enmk merged commit 68094f3 into ClickHouse:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Enmk