Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support open telemetry #232

Merged
merged 1 commit into from
Oct 27, 2022
Merged

support open telemetry #232

merged 1 commit into from
Oct 27, 2022

Conversation

den818
Copy link
Contributor

@den818 den818 commented Oct 21, 2022

No description provided.

Copy link
Collaborator

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but please address highlighted issues.

ut/client_ut.cpp Outdated Show resolved Hide resolved
ut/client_ut.cpp Outdated Show resolved Hide resolved
clickhouse/base/string_utils.h Outdated Show resolved Hide resolved
clickhouse/base/string_utils.h Outdated Show resolved Hide resolved
clickhouse/base/string_utils.h Outdated Show resolved Hide resolved
clickhouse/base/string_utils.h Outdated Show resolved Hide resolved
clickhouse/client.cpp Outdated Show resolved Hide resolved
@den818 den818 force-pushed the OPENTELEMETRY branch 3 times, most recently from 0f85ab9 to 56408ad Compare October 25, 2022 08:50
@den818 den818 requested a review from Enmk October 25, 2022 12:07
Copy link
Collaborator

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enmk Enmk merged commit 3cd6f52 into ClickHouse:master Oct 27, 2022
@den818 den818 deleted the OPENTELEMETRY branch October 27, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants