Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile warning #312

Merged
merged 7 commits into from
Jun 14, 2023
Merged

Fix compile warning #312

merged 7 commits into from
Jun 14, 2023

Conversation

1261385937
Copy link
Contributor

@1261385937 1261385937 commented Jun 10, 2023 •
edited
Loading

add more strict syntax check and fix compile error for all platform
Too many warnings make me crazy, especially windows pltform

@1261385937
Copy link
Contributor Author

@Enmk
Due to large data, i should start at least 4 threads for doing batch insertion.
Is it significant if adding async interface ?

#305 is a nice idea

@Enmk
Copy link
Collaborator

Enmk commented Jun 10, 2023

@Enmk

Due to large data, i should start at least 4 threads for doing batch insertion.

Is it significant if adding async interface ?

#305 is a nice idea

Let's keep discussion of 305 in the corresponding thread. In short: any PRs are welcome if you have an implementation idea - please submit it, and we can work out the details

Enmk
Enmk requested changes Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

There are minor fixes/comments required here and there, please address those.

clickhouse/CMakeLists.txt Outdated Show resolved Hide resolved
clickhouse/CMakeLists.txt Outdated Show resolved Hide resolved
clickhouse/CMakeLists.txt Show resolved Hide resolved
clickhouse/base/sslsocket.cpp Show resolved Hide resolved
clickhouse/base/sslsocket.cpp Show resolved Hide resolved
@1261385937 1261385937 requested a review from Enmk June 12, 2023 05:20
@Enmk
SSLSocketOutput::DoWrite exception in case of too much data
6a9f077 
This is a temporary solution and should be changed to invoking SSL_write() as many times are required until all data is written
@Enmk Enmk merged commit 45680f2 into ClickHouse:master Jun 14, 2023
@1261385937 1261385937 deleted the fix-compile-warning branch September 14, 2023 06:24
@p-linnane p-linnane mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enmk Enmk Awaiting requested review from Enmk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1261385937 @Enmk