Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to explicitly access LowCardinality<WrappedColumn> columns as WrappedColumn #79

Merged
merged 4 commits into from
Mar 24, 2021

Conversation

Enmk
Copy link
Collaborator

@Enmk Enmk commented Mar 4, 2021

Ease migration of the old codebases, which can't afford to switch to using ColumnLowCardinalityT or ColumnLowCardinality directly, but still want to benefit from smaller on-wire LowCardinality bandwidth footprint.

Please see test for details.

Copy link
Collaborator

@traceon traceon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, LGTM otherwise.

ut/columns_ut.cpp Outdated Show resolved Hide resolved
clickhouse/columns/lowcardinality.h Outdated Show resolved Hide resolved
Enmk and others added 2 commits March 24, 2021 14:53
Co-authored-by: Denis Glazachev <traceon@users.noreply.github.com>
@traceon traceon merged commit 13079ad into ClickHouse:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants