Fixes #66 to allow using absl::int128 as Int128 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests: * Basic cases for Int128 numeric columns * Parsing Decimal128 values from string (basic and with overflow) Known limitations: * Overflow checks are broken for std::numeric_limits<Int128>::min() when there is no __int128.
Tests for ItemView contructor
Enmk
changed the title
Fragile implementation of ItemView::ValidateData And several other minor issues.
traceon
approved these changes
Mar 24, 2021
This was referenced Mar 24, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed multiple compile-time issues using
absl::int128asclickhouse::Int128Fixed storing
Int128value toItemViewAdded tests:
Int128numeric columnsDecimal128values from a string (basic and with overflow)ItemViewconstruction tests (both positive and negative cases)Known limitations:
Closes: #73
Closes: #72