Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PreparBatch #1280

Closed
GanBob opened this issue Apr 22, 2024 · 0 comments · Fixed by #1290
Closed

PreparBatch #1280

GanBob opened this issue Apr 22, 2024 · 0 comments · Fixed by #1290
Assignees
@jkaflik
Labels
bug needs triage

Comments

@GanBob
Copy link

GanBob commented Apr 22, 2024

In the conn_batch.go Lines 55-57

if !strings.HasSuffix(strings.TrimSpace(strings.ToUpper(query)), "VALUES") { query += " VALUES" }
If I have a table named "xxx_values",this code processing is a bit incomplete.
e.g
insert into sqt_values
wanted: insert into sqt_values values
but: insert into sqt_values
@jkaflik jkaflik self-assigned this Apr 22, 2024
@Wang Wang mentioned this issue Apr 30, 2024
Closed
Wang added a commit to Wang/clickhouse-go that referenced this issue May 2, 2024
@Wang
fixed issue ClickHouse#1280
fe31f99
@Wang Wang mentioned this issue May 2, 2024
Merged
jkaflik pushed a commit that referenced this issue May 8, 2024
@Wang
Fix prepare batch does not break on values substring in table name (#…
a9bbb75 
…1290)

* fxied issue 1280

* Update 1280_test.go

* Update 1280_test.go

* fixed issue #1280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkaflik jkaflik

Labels
bug needs triage
Projects
None yet
Milestone
No milestone
2 participants
@jkaflik @GanBob