Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INSERT INTO quoted_table_name fails with "cannot get table name from query" #715

Closed
wizzard0 opened this issue Aug 10, 2022 · 0 comments · Fixed by #716
Closed

INSERT INTO quoted_table_name fails with "cannot get table name from query" #715

wizzard0 opened this issue Aug 10, 2022 · 0 comments · Fixed by #716

Comments

@wizzard0
Copy link
Contributor

Issue description

Insert should succeed.

The regex

var splitHttpInsertRe = regexp.MustCompile(`(?i)^INSERT INTO\s([\w.]+)`)

supports unquoted table name only

Configuration

OS: macOS Monterey AArch64

Driver version: v2.3.0-beta.2

Go version: 1.8.5

ClickHouse Server version: 22.8.1.1316
wizzard0 added a commit to wizzard0/clickhouse-go that referenced this issue Aug 10, 2022
@wizzard0
Closes ClickHouse#715 (quoted table name in INSERT INTO)
010475a 
Closes ClickHouse#715 by extending the regex with optional backticks
@wizzard0 wizzard0 mentioned this issue Aug 10, 2022
Closed
wizzard0 added a commit to wizzard0/clickhouse-go that referenced this issue Aug 10, 2022
@wizzard0
Closes ClickHouse#715 (quoted table name in INSERT INTO)
b5fe2d3 
Closes ClickHouse#715 by extending the regex with optional backticks
@wizzard0 wizzard0 mentioned this issue Aug 10, 2022
Merged
larry-cdn77 pushed a commit to larry-cdn77/clickhouse-go that referenced this issue Aug 11, 2022
@gingerwizard
Merge pull request ClickHouse#716 from wizzard0/patch-1
6665902 
Closes ClickHouse#715 (quoted table name in INSERT INTO)
@wizzard0 wizzard0 mentioned this issue Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@wizzard0