Add sql.Valuer support for all types #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing implementation of strings value.Valuer only checked if the return type was a `string` and none of the other supported types and so changed to send it back through AppendRow again for those supported types to be checked again.
|
|
|
Hi @deankarn |
jkaflik
reviewed
Nov 29, 2023
jkaflik
approved these changes
Nov 29, 2023
|
@deankarn there is a conflict to be resolved. Can you take a look? I would like to release tomorrow. |
|
@jkaflik I will make it my priority as soon as I am at my desk in an hour. |
|
@jkaflik I have resolved the conflicts in the contributors list files, no code changes whatsoever :) |
TylerHelmuth
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Dec 13, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) | require | minor | `v2.15.0` -> `v2.16.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.16.0`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2160-2023-12-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.15.0...v2.16.0) #### What's Changed ##### Enhancements 🎉 - Add sql.Valuer support for all types by [@​deankarn](https://github.com/deankarn) in [ClickHouse/clickhouse-go#1144 ##### Fixes 🐛 - Fix DateTime64 range to actual supported range per ClickHouse documentation by [@​phil-schreiber](https://github.com/phil-schreiber) in [ClickHouse/clickhouse-go#1148 #### New Contributors - [@​phil-schreiber](https://github.com/phil-schreiber) made their first contribution in [ClickHouse/clickhouse-go#1148 - [@​deankarn](https://github.com/deankarn) made their first contribution in [ClickHouse/clickhouse-go#1144 **Full Changelog**: ClickHouse/clickhouse-go@v2.15.0...v2.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
](https://renovatebot.com){kind=link}
…-telemetry#29809) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) | require | minor | `v2.15.0` -> `v2.16.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.16.0`](https://github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2160-2023-12-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://github.com/ClickHouse/clickhouse-go/compare/v2.15.0...v2.16.0) #### What's Changed ##### Enhancements 🎉 - Add sql.Valuer support for all types by [@&open-telemetry#8203;deankarn](https://github.com/deankarn) in [ClickHouse/clickhouse-go#1144 ##### Fixes 🐛 - Fix DateTime64 range to actual supported range per ClickHouse documentation by [@&open-telemetry#8203;phil-schreiber](https://github.com/phil-schreiber) in [ClickHouse/clickhouse-go#1148 #### New Contributors - [@&open-telemetry#8203;phil-schreiber](https://github.com/phil-schreiber) made their first contribution in [ClickHouse/clickhouse-go#1148 - [@&open-telemetry#8203;deankarn](https://github.com/deankarn) made their first contribution in [ClickHouse/clickhouse-go#1144 **Full Changelog**: ClickHouse/clickhouse-go@v2.15.0...v2.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
sql.Valuersupport for all types, except experimental type JSON.Resolves #1143 #997
Checklist
Delete items not relevant to your PR: