fixing timezone problem #1182
Closed
fixing timezone problem #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I have signed the agreement.
CLAassistant ***@***.***>, 24 Oca 2024 Çar, 17:22 tarihinde
şunu yazdı:
… [image: CLA assistant check]
<https://cla-assistant.io/ClickHouse/clickhouse-go?pullRequest=1182>
Thank you for your submission! We really appreciate it. Like many open
source projects, we ask that you sign our Contributor License Agreement
<https://cla-assistant.io/ClickHouse/clickhouse-go?pullRequest=1182>
before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us
recheck
<https://cla-assistant.io/check/ClickHouse/clickhouse-go?pullRequest=1182>
it.
—
Reply to this email directly, view it on GitHub
<#1182 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6NWXGZ7KUWLFVHRM7PB6QDYQEKLZAVCNFSM6AAAAABCI3CZ5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYGIZTANBRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hi @Eyup-Devop I have added a test case and fixed implementation for this logic: #1184 |
|
HelloIt is good to hear that is working. I dont need to work with forked repository anymore. Thank youEYÜP SARALKuba Kaflik ***@***.***> şunları yazdı (29 Oca 2024 14:21):
Hi @Eyup-Devop I have added a test case and fixed implementation for this logic: #1184
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When Etc/GMT-3 and Etc/GMT-2 timezone used with toDateTime function, query is created as Etc/GMT-11. To solve this problem, the time.Format function must be used differently.