Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable retries for broken pipes & connection rests during Flush() calls #1421

Closed
wants to merge 2 commits into from
Closed

Enable retries for broken pipes & connection rests during Flush() calls #1421

wants to merge 2 commits into from

Conversation

rgettys-tesla
Copy link
Contributor

@rgettys-tesla rgettys-tesla commented Oct 10, 2024 •
edited
Loading

Summary

Fixes #1420 : Enable retries for broken pipes & connection resets Flush() calls

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • [NA] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jkaflik
jkaflik approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgettys-tesla thanks for identifying this issue and providing a fix! LGTM

jkaflik added a commit that referenced this pull request Oct 15, 2024
@jkaflik
Use a dedicated test environment for broken connection test recover #…
957b9f6 
…1421
@jkaflik
Copy link
Contributor

jkaflik commented Oct 15, 2024

@rgettys-tesla, Unfortunately, test messes with a container used in other tests. I dunno why as we don't really parallelize tests, however, it would be safe to use a dedicated container for this specific test case.

Please take a look on my branch: main...rgettys-tesla/main
This also moves test case file into another package. Feel free to rebase or we can continue from my branch. Please let me know!

@rgettys-tesla
Copy link
Contributor Author

Yeah, that's strange! I rebuild the container env for this reason. Will take a look.

@rgettys-tesla
Copy link
Contributor Author

@rgettys-tesla, Unfortunately, test messes with a container used in other tests. I dunno why as we don't really parallelize tests, however, it would be safe to use a dedicated container for this specific test case.

Please take a look on my branch: main...rgettys-tesla/main This also moves test case file into another package. Feel free to rebase or we can continue from my branch. Please let me know!

Hi Kuba, Your branch LGTM. We can continue from your branch if you like!

@jkaflik jkaflik mentioned this pull request Oct 16, 2024
Merged
@jkaflik
Copy link
Contributor

jkaflik commented Oct 16, 2024

Thanks @rgettys-tesla. Let's continue in a new PR then!

@jkaflik jkaflik closed this Oct 16, 2024
jkaflik added a commit that referenced this pull request Oct 16, 2024
@jkaflik @rgettys-tesla
Retry on broken pipe in batch (#1423)
02efdee 
* Release connections on error during Flush()

* Add test to illustrate broken batch flushes

* Use a dedicated test environment for broken connection test recover #1421

---------

Co-authored-by: Robert Gettys <rgettys@tesla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaflik jkaflik jkaflik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection resets/broken pipes during batch flush are unrecoverable
3 participants
@rgettys-tesla @CLAassistant @jkaflik