Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert byte slices to string #688

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Convert byte slices to string #688

merged 2 commits into from
Jul 25, 2022

Conversation

a-dot
Copy link
Contributor

@a-dot a-dot commented Jul 24, 2022

This PR closes #687

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@a-dot a-dot mentioned this pull request Jul 24, 2022
Closed
gingerwizard
gingerwizard requested changes Jul 24, 2022
View reviewed changes
Copy link
Collaborator

@gingerwizard gingerwizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to support in Append as well

@a-dot a-dot requested a review from gingerwizard July 24, 2022 13:49
@gingerwizard gingerwizard merged commit 5afde64 into ClickHouse:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gingerwizard gingerwizard Awaiting requested review from gingerwizard

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't insert a slice of bytes into a String
3 participants
@a-dot @CLAassistant @gingerwizard