-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix json with nil will get error #824
Conversation
Rather than test on the function level - we don't have any other tests like this. Can you do a high level set of inserts/queries which reproduce the issue please? Add to https://github.com/ClickHouse/clickhouse-go/blob/main/tests/json_test.go |
I don't know all the implementations very well, it's a bit of a hassle, I'll give it a try |
Is it okay to submit a commit like this? |
OK post some JSON which recreates your issue @ACV-er - I'll write a test. |
What are these errors? It doesn't look like a problem with the code。 @gingerwizard |
@ACV-er our cloud CI tests wont pass for external contributors as you don't have access to cluster secrets. Needs to be fixed. I'll test locally today and merge. thanks again. Will make 2.4.2 - likely end of week. |
resoved: #823