Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure a connection is not used when its
ConnMaxLifetime
is exceededCurrently, the
ConnMaxLifetime
is only checked in therelease
method. So a connection may be valid when added to the "idle" pool, but expired when "acquired".In our application, the TCP socket is only alive for a few minutes, and I don't know why, but the
isBad()
method does not detect any issues.But then when a query is sent to the ClickHouse server, we end up with
broken pipe
orEOF
errors