Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Custom http header, query parameters and URL parsing #1782

Closed
chernser opened this issue Aug 21, 2024 · 1 comment · Fixed by #1841
Closed

[client-v2] Custom http header, query parameters and URL parsing #1782

chernser opened this issue Aug 21, 2024 · 1 comment · Fixed by #1841
Milestone

Comments

@chernser
Copy link
Contributor

chernser commented Aug 21, 2024

Describe the bug

It should be possible to pass custom HTTP headers to the request

Closes #1750

@chernser chernser added this to the 0.7.0 milestone Aug 21, 2024
@chernser
Copy link
Contributor Author

chernser commented Sep 23, 2024

I would propose next solution:

  • create a client builder method: setHttpHeaders(Map<String, String> headers) and accept values as String in format supporting multiple values
  • reserve http_header_ prefix for options that should be passed as header values. This is required for cases when we parse connection URL into properties
  • create a client builder method: setQueryOptions(Map<String, String> options) to be passed as query parameters
  • reserve query_p_ prefix for options that should be passes as query parameters. This is required for cases when we parse connection URL into properties.

Should be similar to JavaScript Client

@chernser chernser changed the title [client-v2] Pass Custom HTTP Headers [client-v2] Custom http header, query parameters and URL parsing Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant