[client-v2] Added options for additional headers and server settings #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mzitnik
reviewed
Sep 29, 2024
| @DataProvider(name = "testPropertyWithValueList_endpoints") | ||
| public static Object[][] endpoints() { | ||
| return new Object[][] { | ||
| { "http://server1:9090/my_db?custom_settings=param1=value1,param2=value2", 1, new String[]{"http://server1:9090/"} }, |
There was a problem hiding this comment.
it is not exactly URL - it is client endpoints spec. It may have multiple hosts for example.
Current example has custom setting with multiple key-value pairs (what would be URL encoded to make it Web URL, but we do not need to do this until we send request - so it is all fine)
| @@ -95,14 +96,19 @@ static ClickHouseNodes create(String endpoints, Map<?, ?> defaultOptions) { | |||
| } | |||
|
|
|||
| int endIndex = i; | |||
| // parsing host name | |||
There was a problem hiding this comment.
I do not fully understand if we are planning to remove this module.
why we are changing ClickHouseNodes
There was a problem hiding this comment.
This is base module for whole client. I'm changing it to fix a bug in it.
We will use this module for a while because it contains some base classes like ClickhouseClientOptions
mzitnik
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new configuration options for client and operations:
httpHeader- to set additional http headers or override already set one'sserverSetting- to pass settings to a server (thru query parameters in case of HTTP)Closes #1782
Closes #1750
Closes #1665
Checklist
Delete items not relevant to your PR: