Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Attach TimeZone to a QueryResponse & use TimeZone settings in binary readers #1763

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Aug 4, 2024

Summary

There are two options for the timezone for parsing DateTime values:

  • use server timezone (pre-fetch or header)
  • use user specified timezone

This PR implement these options when old or new implementation are used.

Closes #955

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser marked this pull request as ready for review August 5, 2024 20:15
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
51.6% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@chernser chernser merged commit 9c309e2 into main Aug 6, 2024
65 of 66 checks passed
@chernser chernser deleted the feat_clientv2_timezone branch August 6, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useServerTimeZone == true doesn't work
2 participants