[client-v2] Including support for bitmap serialization #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @javiercj93 thanks for submitting this! Would you mind adding a test to cover this data as well? |
Thanks for reviewing @Paultagoras! appreciate it! Please let me know if this change in an existing test would be enough or we need something more specific. |
chernser
changed the title
|
@javiercj93 would you please resolve conflicts in the merge? |
|
@chernser done, conflicts resolved |
|
@javiercj93 appreciate it! Thank you! |
chernser
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have a table structure which has a few aggregate function columns (groupBitmap) and I was unable to directly insert into it as the ClickhouseBitmapColumn was throwing an unsupported data type when serializing.
Checking the code I saw there was a
writeBitmapfunction implemented in the BinaryStreamUtils but it was not being used in the SerializerUtils. Not sure if there was any reason behind it or if there are any other considerations to not use it that I am not aware of.I tested the change and I was able to successfully import in a column with such data type.