[jdbc] added some tests and fixes #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Paultagoras
approved these changes
Nov 29, 2024
| checkClosed(); | ||
| StatementType type = parseStatementType(sql); | ||
|
|
||
| if (type == StatementType.SELECT) { | ||
| executeQuery(sql, settings); | ||
| executeQuery(sql, settings); // keep open to allow getResultSet() |
There was a problem hiding this comment.
Do we eventually close it?
There was a problem hiding this comment.
it should be tested
- execute query
- get result set and not close
- execute another query
- get new result set
- try to do something on the first result set
| /** | ||
| * JDBC driver specific properties. Do not include any ClickHouse client properties here. | ||
| */ | ||
| public enum DriveProperties { |
There was a problem hiding this comment.
Shouldn't this be DriverProperties?
There was a problem hiding this comment.
yes, it should - we need to fix it.
| } | ||
|
|
||
| private Connection getConnection() throws SQLException { | ||
| return DriverManager.getConnection(getEndpointString(isCloud())); |
There was a problem hiding this comment.
In theory this could be restored to just the one line
There was a problem hiding this comment.
it is true - but I think it is not my code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Next things are done:
integrationto make them run while CI build and maveninstallnullsAreSortedHighandsupportsCatalogsInIndexDefinitionsgetTablesto return schema, typegetTableTypesto return what is stored in DBgetColumnscorrect types, flags, precision, decimal digits ...Relates to: #1974
Checklist
Delete items not relevant to your PR: