Support chDB as a driver #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: first working implementation of chdb as driver
|
|
|
also tagging @auxten if you have insight on the chDB part |
|
It looks great. I'm here for any issue or question :) |
ThomAub
commented
Oct 21, 2024
| chdb-dev: | ||
| type: clickhouse | ||
| driver: chdb | ||
| chdb_state_dir: "chdb_state" |
There was a problem hiding this comment.
This should be in dbt target provided folder
| type: clickhouse | ||
| driver: chdb | ||
| chdb_state_dir: "chdb_state" | ||
| chdb_dump_dir: "dump" |
There was a problem hiding this comment.
Maybe more granular and able to load single file or glob expression
|
@ThomAub There are some lint issues to fix, and we also need unit and integration tests. You can "Allow edits from maintainers." |
|
Hi folks, Thank you for your contribution! Before reviewing your PR, please add the following:
Looking forward to reviewing this! |
…tories fix: Get all .sql files in all subdirectories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a first proposition for #297. It's currently working for our use case of embedded ClickHouse for unit tests with DBT.
It would be great to have some feedback in the direction of this feature implementation !
We would also be interested in how should we add Unit and integration tests or even a tutorial ?
Checklist
Delete items not relevant to your PR: