Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing 2025 NDC Tracker feedback #1698

Merged
merged 22 commits into from
Oct 10, 2024
Merged

Conversation

SARodrigues
Copy link
Collaborator

@SARodrigues SARodrigues commented Oct 9, 2024

Feedback

Timeline

  • 1.1 - Change the name of the module from “2025 NDC Tracker” to “NDC Tracker”
  • 1.2 - Change title of timeline to "Latest NDC Submissions"
  • 1.3 - Question for Vizzuality: What happens if we have +8 submission on a same day?
  • TBD - (HOLD) Comment on the line just below the main title "NDC Tracker”

Top line numbers and GHG bar

  • 2.1 - Copy changes to title 
  • 2.2 - Copy changes to subtitle
  • 2.3 - Adjust the titles of the white boxes
  • 2.4 - Could we get the spacing of "Total Countries” and “Global Emissions” a bit more compact with the question and answer?
  • 2.5 - Add a yellow button in line with the header
  • 2.6 - Toggle bar taking too long to change repeatedly from one option to the other
    Note: (from @SARodrigues): we may want to leave this one for last, as it may not be straighforward. It may be due to the way that these switches work; you need to click on a blank area. We can investigate and adjust
  • 2.7 - The Bar’s tooltip should show country’s full name
  • 2.8 - Should the GHG bar showing the same color of the country on the map?
    Note: (from @SARodrigues). Nothing was adjusted here, it looks like the GHG bar is showing the correct colors as defined; it seems to be the map that isn't, due to the latest data upload's changes. We, however, need to make sure we have a TODO/task to ensure map colors are correct.
  • 2.9 - Info button: We have updated the “metadata_sources.csv” file on the backend
    Note: (from @SARodrigues ) Feedback file mentions a "NDC_Tracker" slug, but the endpoint does not have that. It does, however, have an "2025 NDC Tracker". We may want to re-check this when new data is uploaded. Respective endpoint for checking: https://staging.climatewatchdata.org/api/v1/metadata/
  • 2.10 - How to count the EU
    • Countries cards
    • GHG Emissions chart
    • Map
    • Table

Map

  • 3.1 - Remove extra arrow from tooltip
    marked as apparently solved, possibly no intervention needed, we may want to double check
  • 3.2 - “No New NDC” countries should be dark grey
  • 3.3 - Adjust the legend in the map
  • 4.3b - Update the tooltip on the map of the "No New NDC" countries so that they simply show a label that says “No New NDC” instead of the full tooltip with all the NDC Comparison indicators
  • TBD (HOLD) When clicking on a country in the map, it should redirect me to a custom comparison with the 2025 NDC, but the custom comparison only has 2nd NDC as the latest submission

Table

  • 4.1 - For the NDC status in the table, make that consistent with the map and bar chart above. "No New NDC" should have the same color as above. (gray)
  • 4.2 - Adjustments to the Initials and legends of the NDC Comparison indicators
  • 4.3 - Remove countries without a submission from the table

General

  • 5.1 - Name of the Module

@SARodrigues SARodrigues self-assigned this Oct 9, 2024
SARodrigues and others added 21 commits October 9, 2024 15:42
…r-feedback-s-2

(2025 Tracker) Addressing GHG Emissions chart / country cards feedback
…r-feedback-s-3

(2.4) 2025 ndc tracker feedback - Make left titles on country cards spacing smaller
…r-feedback-s-4

(2.5) Add 'Explore NDC Content' button to 2025 tracker chart section
…izzuality/climate-watch into 2025-ndc-tracker-feedback
@Bluesmile82 Bluesmile82 marked this pull request as ready for review October 10, 2024 14:05
@Bluesmile82 Bluesmile82 merged commit 48dd480 into develop Oct 10, 2024
2 of 3 checks passed
@Bluesmile82 Bluesmile82 deleted the 2025-ndc-tracker-feedback branch October 10, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants