-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing 2025 NDC Tracker feedback #1698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…25 emissions chart
…r-feedback-s-2 (2025 Tracker) Addressing GHG Emissions chart / country cards feedback
…r-feedback-s-3 (2.4) 2025 ndc tracker feedback - Make left titles on country cards spacing smaller
…r-feedback-s-4 (2.5) Add 'Explore NDC Content' button to 2025 tracker chart section
…izzuality/climate-watch into 2025-ndc-tracker-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback
Timeline
Top line numbers and GHG bar
Note: (from @SARodrigues): we may want to leave this one for last, as it may not be straighforward. It may be due to the way that these switches work; you need to click on a blank area. We can investigate and adjust
Note: (from @SARodrigues). Nothing was adjusted here, it looks like the GHG bar is showing the correct colors as defined; it seems to be the map that isn't, due to the latest data upload's changes. We, however, need to make sure we have a TODO/task to ensure map colors are correct.
Note: (from @SARodrigues ) Feedback file mentions a "NDC_Tracker" slug, but the endpoint does not have that. It does, however, have an "2025 NDC Tracker". We may want to re-check this when new data is uploaded. Respective endpoint for checking: https://staging.climatewatchdata.org/api/v1/metadata/
Map
marked as apparently solved, possibly no intervention needed, we may want to double check
Table
General