Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Failed Analysis ] CNVpytor float values not accepted by bcftools #1152

Closed
mathiasbio opened this issue May 2, 2023 · 5 comments
Closed
Labels
Bug Something isn't working

Comments

@mathiasbio
Copy link
Collaborator

Case or sample information
Internal sample id or case id: modelstag
Amount read-pairs: 2688801506
Sequence type (WGS): Tumor only

Error message
Rule that failed: bcftools_quality_filter_svdb

Error message:

[W::bcf_hdr_parse_line] Dropped trailing junk from header line '"##FORMAT=<ID=GT,Number=1,Type=String,Description=\"Genotype\">;"'
[E::vcf_parse_format] Invalid character '.' in 'CN' FORMAT field at 8:35400001
[E::vcf_parse_format] Invalid character '.' in 'CN' FORMAT field at 8:46900001
Error: VCF parse error

Link to the error message

/home/proj/production/cancer/cases/modelstag/logs/BALSAMIC.modelstag.bcftools_quality_filter_svdb.6.sh_4695700.err

Reason for failure

CNVpytor outputs float values for CN sometimes:
8 35400001 CNVpytor_dup8 . . PASS INFOfieldremoved GT:CN ./1:2.73

Don't know if this is intentional or a bug from CNVpytor!

If workflow, which rules

bcftools_quality_filter_svdb in WGS tumor only

Version (please complete the following information):
balsamic --version 11.0.2

Additional context
Add any other context about the problem here. For e.g. amount sequencing reads or other parameters that are of interest.

@mathiasbio mathiasbio added the Bug Something isn't working label May 2, 2023
@pbiology pbiology added this to BALSAMIC May 2, 2023
@github-project-automation github-project-automation bot moved this to Todo in BALSAMIC May 2, 2023
@pbiology
Copy link
Contributor

pbiology commented Nov 1, 2023

@mathiasbio can you assign gain/urgency/effort labels to this?

@pbiology
Copy link
Contributor

pbiology commented Nov 1, 2023

Or was this solved by #1183 and #1182 ?

@khurrammaqbool
Copy link
Collaborator

It was fixed in CNVpytor abyzovlab/CNVpytor#178 and we have added the latest version of CNVpytor in develop.

@mathiasbio
Copy link
Collaborator Author

I didn't know about the CNVpytor update fixing it, that's great. I guess my fix is unnecessary then at this point, did you remove the sed command I added @khurrammaqbool ? I guess it doesn't matter if it's there either, but it would be cleaner if we removed it I suppose when it's not necessary anymore : )

@mathiasbio
Copy link
Collaborator Author

Removed the sed command in #1310 and as the issue has already been solved in the CNVpytor update I'll close this issue

@github-project-automation github-project-automation bot moved this from Todo to Completed in BALSAMIC Nov 2, 2023
mathiasbio added a commit that referenced this issue Nov 4, 2023
This PR aims to change the name of the sample columns in the final VCFs to match the changes in the scout_load.yaml for sample-id, which will use LIMS-ID instead of TUMOR/NORMAL. (Clinical-Genomics/cg#2650)

Added:
- New rule to create namemap to translate sample type names in vcf header to sampleID

Changed:
- Renamed names of sample columns in final vcf (clinical.pass.vcf.gz) to sampleID

Removed:
- Removed sed command in CNVpytor rule introduced here (fix: cnvpytor header float #1182) as it has been fixed by updating CNVpytor and is no longer necessary ([ Failed Analysis ] CNVpytor float values not accepted by bcftools #1152)
@pbiology pbiology moved this from Completed to Archived in BALSAMIC Nov 10, 2023
@pbiology pbiology removed this from BALSAMIC Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants