Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redundant BALSAMIC files #890

Closed
ashwini06 opened this issue Mar 17, 2022 · 1 comment
Closed

redundant BALSAMIC files #890

ashwini06 opened this issue Mar 17, 2022 · 1 comment

Comments

@ashwini06
Copy link
Contributor

Purpose of this files in BALSAMIC. I think, these files are no longer used, can we remove them safely? @hassanfa Can you comment on this?

https://github.com/Clinical-Genomics/BALSAMIC/tree/master/BALSAMIC/assets/sentieon_models

https://github.com/Clinical-Genomics/BALSAMIC/blob/develop/BALSAMIC/config/MSK_impact.json

https://github.com/Clinical-Genomics/BALSAMIC/blob/develop/BALSAMIC/config/MSK_impact_noStrelka.json
@hassanfa
Copy link
Contributor

MSK impact files can be removed. But Sentieon models are in use for the ML model. I'd keep them.

@hassanfa hassanfa removed their assignment Mar 18, 2022
@ashwini06 ashwini06 mentioned this issue Apr 5, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hassanfa @ashwini06