Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: redundant files and varaibles from balsamic #903

Merged
merged 6 commits into from
Apr 6, 2022

Conversation

ashwini06
Copy link
Contributor

This PR:

Related #890

  • Removes MSK_impact and MSK_impact_noStrelka json files from config
  • Cleans up strelka, pindel , mutect2 variables from BALSAMIC

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #903 (5bb4071) into develop (a80860c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #903   +/-   ##
========================================
  Coverage    99.54%   99.54%           
========================================
  Files           29       29           
  Lines         1770     1770           
========================================
  Hits          1762     1762           
  Misses           8        8           
Flag Coverage Δ
unittests 99.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
BALSAMIC/constants/common.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a80860c...5bb4071. Read the comment docs.

Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ashwini06 ashwini06 merged commit cb10e60 into develop Apr 6, 2022
@ashwini06 ashwini06 deleted the refactor/redudant_files branch April 6, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants