Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sam validation error #1019

Merged
merged 3 commits into from
Nov 16, 2022
Merged

fix: sam validation error #1019

merged 3 commits into from
Nov 16, 2022

Conversation

khurrammaqbool
Copy link
Collaborator

This PR:

Changed: Fix issue 1015, sam validation error by adding fixmate command.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@khurrammaqbool khurrammaqbool self-assigned this Oct 31, 2022
@khurrammaqbool khurrammaqbool marked this pull request as draft October 31, 2022 11:47
@khurrammaqbool khurrammaqbool linked an issue Oct 31, 2022 that may be closed by this pull request
SAM validation error in mergeBam rule #1015
Closed
@codecov
Copy link

codecov bot commented Oct 31, 2022 •
edited
Loading

Codecov Report

Base: 99.25% // Head: 99.25% // No change to project coverage 👍

Coverage data is based on head (33efbba) compared to base (4ff1b8f).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1019   +/-   ##
========================================
  Coverage    99.25%   99.25%           
========================================
  Files           28       28           
  Lines         1747     1747           
========================================
  Hits          1734     1734           
  Misses          13       13
Flag Coverage Δ
unittests 99.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@khurrammaqbool khurrammaqbool changed the title fix: fix issue #1015 fix: fix sam validation error issue #1015 Oct 31, 2022
@khurrammaqbool khurrammaqbool changed the title fix: fix sam validation error issue #1015 fix: sam validation error issue #1015 Oct 31, 2022
@khurrammaqbool khurrammaqbool changed the title fix: sam validation error issue #1015 fix: sam validation error Oct 31, 2022
@khurrammaqbool khurrammaqbool marked this pull request as ready for review November 16, 2022 09:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ivadym
ivadym approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@khurrammaqbool khurrammaqbool merged commit 95b49f3 into develop Nov 16, 2022
@khurrammaqbool khurrammaqbool deleted the fix/fix_mate branch November 16, 2022 12:17
@khurrammaqbool khurrammaqbool mentioned this pull request Nov 26, 2022
Closed
60 tasks
@khurrammaqbool khurrammaqbool mentioned this pull request Dec 5, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivadym ivadym ivadym approved these changes

@hassanfa hassanfa Awaiting requested review from hassanfa

@ashwini06 ashwini06 Awaiting requested review from ashwini06

Assignees

@khurrammaqbool khurrammaqbool

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SAM validation error in mergeBam rule
2 participants
@khurrammaqbool @ivadym