Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bcftools varcall py 3 container #1035

Merged
merged 10 commits into from
Dec 2, 2022
Merged

fix: bcftools varcall py 3 container #1035

merged 10 commits into from
Dec 2, 2022

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Dec 1, 2022

This PR:

Set channels for varcall_py3 container.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 99.25% // Head: 99.25% // No change to project coverage 👍

Coverage data is based on head (20ec00f) compared to base (bd87398).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1035   +/-   ##
========================================
  Coverage    99.25%   99.25%           
========================================
  Files           28       28           
  Lines         1751     1751           
========================================
  Hits          1738     1738           
  Misses          13       13           
Flag Coverage Δ
unittests 99.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ivadym ivadym closed this Dec 1, 2022
@ivadym ivadym reopened this Dec 2, 2022
@khurrammaqbool khurrammaqbool linked an issue Dec 2, 2022 that may be closed by this pull request
@ivadym ivadym marked this pull request as ready for review December 2, 2022 14:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khurrammaqbool
Copy link
Collaborator

👍 💯 🥇 🙏 🤞

@ivadym ivadym merged commit 9f4685f into develop Dec 2, 2022
@ivadym ivadym deleted the fix-bftools branch December 2, 2022 16:07
@khurrammaqbool khurrammaqbool mentioned this pull request Dec 5, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bcftools in varcall_py3 container fails
2 participants