Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect raw TNscope delivered VCF #1042

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Dec 5, 2022

This PR:

Fixed: Incorrect raw TNscope VCF delivered. We were delivering the ALL.tnscope file, including SNVs and SVs

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 99.25% // Head: 99.25% // No change to project coverage 👍

Coverage data is based on head (a0a13aa) compared to base (dc4cc9e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1042   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          28       28           
  Lines        1751     1751           
=======================================
  Hits         1738     1738           
  Misses         13       13           
Flag Coverage Δ
unittests 99.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
BALSAMIC/constants/workflow_rules.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ivadym ivadym changed the title fix: Incorrect raw TNscope VCF delivered fix: Incorrect raw TNscope delivered VCF Dec 5, 2022
@ivadym
Copy link
Contributor Author

ivadym commented Dec 5, 2022

Storing the correct file this time (SNV. and not ALL.):
Screenshot 2022-12-05 at 20 03 56

Copy link
Collaborator

@khurrammaqbool khurrammaqbool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure it is correct for umi as well

@ivadym
Copy link
Contributor Author

ivadym commented Dec 5, 2022

👍
Screenshot 2022-12-05 at 20 49 06

@ivadym ivadym merged commit bf84c9c into master Dec 5, 2022
@ivadym ivadym deleted the fix-tnscope-all-file-storage branch December 5, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants