Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SV quality filter #1051

Merged
merged 5 commits into from
Dec 13, 2022
Merged

fix: SV quality filter #1051

merged 5 commits into from
Dec 13, 2022

Conversation

khurrammaqbool
Copy link
Collaborator

This PR:

Fixed: bfcftools filter command in SV quality filter to not filter out variants that are filtered out as MaxDepth.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 99.25% // Head: 99.25% // No change to project coverage 👍

Coverage data is based on head (532ac48) compared to base (11e9347).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1051   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          29       29           
  Lines        1752     1752           
=======================================
  Hits         1739     1739           
  Misses         13       13           
Flag Coverage Δ
unittests 99.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧯 👍

CHANGELOG.rst Outdated Show resolved Hide resolved
@khurrammaqbool khurrammaqbool linked an issue Dec 13, 2022 that may be closed by this pull request
@ivadym ivadym requested a review from a team December 13, 2022 10:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ivadym ivadym merged commit a0ec35c into master Dec 13, 2022
@ivadym ivadym deleted the fix/quality_filter_sv branch December 13, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FLT3.ITD300 filtered out in manta result
2 participants