Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Parallelize download reference #1065

Merged
merged 6 commits into from
Jan 23, 2023
Merged

Conversation

fevac
Copy link
Contributor

@fevac fevac commented Jan 20, 2023

This PR:

Fixes #1064

Changed: parallelize download of reference files

How to tests:

  • Dry-run of balsamic init --outdir $path2balsamic_cache --cosmic-key "${COSMIC_KEY}" --genome-version hg19 --run-mode local --snakemake-opt "--cores 36" --container-version develop
  • Make sure that download_reference is set for multiple executions (count > 1)
  • Run of balsamic init --outdir $path2balsamic_cache --cosmic-key "${COSMIC_KEY}" --genome-version hg19 --run-mode local --snakemake-opt "--cores 2 --until download_reference" --container-version develop -r

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@fevac
Copy link
Contributor Author

fevac commented Jan 20, 2023

Tests output:

  • balsamic init --outdir path2balsamic_cache --cosmic-key "${COSMIC_KEY}" --genome-version hg19 --run-mode local --snakemake-opt "--cores 36" --container-version develop

image

  • balsamic init --outdir path2balsamic_cache --cosmic-key "${COSMIC_KEY}" --genome-version hg19 --run-mode local --snakemake-opt "--cores 2 -R download_reference --until download_reference" --container-version develop -r

image

  • balsamic init --outdir path2balsamic_cache --cosmic-key "${COSMIC_KEY}" --genome-version hg19 --run-mode local --snakemake-opt "--cores 2 --until download_reference" --container-version develop -r
    OBS: I skipped the download of gnomad.genomes.r2.1.1.sites.vcf.bgz as the file is huge and takes a long time.
    image

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 99.25% // Head: 99.25% // No change to project coverage 👍

Coverage data is based on head (029dc6c) compared to base (491b04c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1065   +/-   ##
========================================
  Coverage    99.25%   99.25%           
========================================
  Files           29       29           
  Lines         1755     1755           
========================================
  Hits          1742     1742           
  Misses          13       13           
Flag Coverage Δ
unittests 99.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fevac fevac changed the base branch from master to develop January 20, 2023 22:47
@fevac fevac changed the title Split download reference Parallelize download reference Jan 23, 2023
@fevac fevac changed the title Parallelize download reference perf: Parallelize download reference Jan 23, 2023
@fevac fevac linked an issue Jan 23, 2023 that may be closed by this pull request
@fevac fevac marked this pull request as ready for review January 23, 2023 08:12
@fevac fevac requested review from a team and ivadym January 23, 2023 08:12
Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🔥

BALSAMIC/workflows/reference.smk Outdated Show resolved Hide resolved
BALSAMIC/workflows/reference.smk Outdated Show resolved Hide resolved
BALSAMIC/workflows/reference.smk Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fevac fevac self-assigned this Jan 23, 2023
@fevac
Copy link
Contributor Author

fevac commented Jan 23, 2023

@ivadym thank you for the review 🌟 Tests on hasta are working, should I merge into develop?

@ivadym
Copy link
Contributor

ivadym commented Jan 23, 2023

Sure, go ahead. It's a good first step to start addressing this issue: #1044

@fevac fevac merged commit face1fb into develop Jan 23, 2023
@fevac fevac deleted the split_download_reference branch January 23, 2023 13:51
@fevac fevac mentioned this pull request Jan 31, 2023
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallelize download_reference rule
2 participants