-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Parallelize download reference #1065
Conversation
Codecov ReportBase: 99.25% // Head: 99.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1065 +/- ##
========================================
Coverage 99.25% 99.25%
========================================
Files 29 29
Lines 1755 1755
========================================
Hits 1742 1742
Misses 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🔥
Kudos, SonarCloud Quality Gate passed! |
@ivadym thank you for the review 🌟 Tests on hasta are working, should I merge into develop? |
Sure, go ahead. It's a good first step to start addressing this issue: #1044 |
This PR:
Fixes #1064
Changed: parallelize download of reference files
How to tests:
balsamic init --outdir $path2balsamic_cache --cosmic-key "${COSMIC_KEY}" --genome-version hg19 --run-mode local --snakemake-opt "--cores 36" --container-version develop
download_reference
is set for multiple executions (count > 1)balsamic init --outdir $path2balsamic_cache --cosmic-key "${COSMIC_KEY}" --genome-version hg19 --run-mode local --snakemake-opt "--cores 2 --until download_reference" --container-version develop -r
Review and tests: