Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change somalier container user to defaultuser #1080

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

fevac
Copy link
Contributor

@fevac fevac commented Jan 31, 2023

This PR:

Addresses security hotspot related to using alpine docker with the default root user in somalier. It changes it to defaultuser instead

Fixed: somalier container user to non-root user

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 99.25% // Head: 99.25% // No change to project coverage 👍

Coverage data is based on head (8431366) compared to base (4dfe4d4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1080   +/-   ##
========================================
  Coverage    99.25%   99.25%           
========================================
  Files           29       29           
  Lines         1755     1755           
========================================
  Hits          1742     1742           
  Misses          13       13           
Flag Coverage Δ
unittests 99.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fevac fevac changed the title Change somalier container user from root to defaultuser fix: change somalier container user to defaultuser Jan 31, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fevac fevac marked this pull request as ready for review January 31, 2023 12:57
@fevac fevac requested review from a team and ivadym January 31, 2023 12:57
Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🤩 We'll have to make these changes for all the containers though (maybe when we start splitting them)

But for now let's hope we don't have any more unexpected github actions complains... 🥵

@fevac fevac merged commit 6376d73 into develop Jan 31, 2023
@fevac fevac deleted the change_root_user_container branch January 31, 2023 14:30
@fevac fevac mentioned this pull request Jan 31, 2023
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants