Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: bump cryptography from 40.0.2 to 41.0.1 #1173

Merged
merged 2 commits into from
Jun 9, 2023
Merged

refactor: bump cryptography from 40.0.2 to 41.0.1 #1173

merged 2 commits into from
Jun 9, 2023

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Jun 7, 2023 •
edited
Loading

This PR:

Addressing security alert: https://github.com/Clinical-Genomics/BALSAMIC/security/dependabot/4

Added:

  • Updated cryptography version to 41.0.1

Review and tests:

  • Tests pass
Screenshot 2023-06-07 at 13 48 44
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym requested a review from a team June 7, 2023 11:12
@ivadym ivadym mentioned this pull request Jun 7, 2023
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 7, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (3ce2615) 99.28% compared to head (fee4a59) 99.28%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1173   +/-   ##
========================================
  Coverage    99.28%   99.28%           
========================================
  Files           29       29           
  Lines         1680     1680           
========================================
  Hits          1668     1668           
  Misses          12       12
Flag Coverage Δ
unittests 99.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mathiasbio
mathiasbio reviewed Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask, what is this package used for in balsamic? : )

@ivadym
Copy link
Contributor Author

ivadym commented Jun 8, 2023

It's not used explicitly, but it's a requirement for pyOpenSSL>=0.13 -> gsutil==5.23, which we use to download some of the references

But it's a very good point, which strategy should we follow with the requirements? It's a good practice to include ALL the dependencies, but we have a large number of them 🤔

mathiasbio
mathiasbio approved these changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🌟 🔥 🧙 🔥 🌟

@ivadym ivadym merged commit 63d8209 into develop Jun 9, 2023
@ivadym ivadym deleted the bump-cryptography branch June 9, 2023 07:30
@ivadym ivadym mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbio mathiasbio mathiasbio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
BALSAMIC
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivadym @mathiasbio