Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pydantic version to <2.0 #1191

Merged
merged 2 commits into from
Jul 4, 2023
Merged

fix: pydantic version to <2.0 #1191

merged 2 commits into from
Jul 4, 2023

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Jul 3, 2023

This PR:

Pydantic v2, which introduced breaking changes, has been released: https://github.com/pydantic/pydantic/releases/tag/v2.0, causing pytest and model misbehaviour.

Changed:

  • Fix Pydantic version (<2.0)

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym requested a review from a team July 3, 2023 14:23
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (82f3915) 99.28% compared to head (9c611a4) 99.28%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1191   +/-   ##
========================================
  Coverage    99.28%   99.28%           
========================================
  Files           29       29           
  Lines         1684     1684           
========================================
  Hits          1672     1672           
  Misses          12       12           
Flag Coverage Δ
unittests 99.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ivadym ivadym requested a review from khurrammaqbool July 3, 2023 14:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

setup.py Show resolved Hide resolved
Copy link
Collaborator

@khurrammaqbool khurrammaqbool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ivadym ivadym merged commit 6d20130 into develop Jul 4, 2023
@ivadym ivadym deleted the fix-pydantic-version branch July 4, 2023 09:19
@ivadym ivadym mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants