Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TIDDIT VCF header #1203

Merged

Conversation

khurrammaqbool
Copy link
Collaborator

This PR:

Fixed: VCF header for SVs.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@khurrammaqbool khurrammaqbool requested a review from a team July 19, 2023 07:59
@khurrammaqbool khurrammaqbool linked an issue Jul 19, 2023 that may be closed by this pull request
2 tasks
@khurrammaqbool khurrammaqbool changed the title fix: SV VCF header fix: TIDDIT VCF header Jul 20, 2023
Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and quick, thanks for fixing this! 🧙
It has been tested with success and I have no comments, so I'm approving this 👍

@khurrammaqbool
Copy link
Collaborator Author

Screenshot 2023-07-21 at 10 00 18

Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

We can't proceed with the merge until the pytest issue is resolved. Please take a look at the pull requests that require review @Clinical-Genomics/cancer-bioinfo:
https://github.com/orgs/Clinical-Genomics/projects/46/views/3

CHANGELOG.rst Outdated Show resolved Hide resolved
@ivadym ivadym changed the base branch from master to release_12.0.2 July 21, 2023 10:45
@ivadym
Copy link
Contributor

ivadym commented Jul 21, 2023

I have created a branch for release v12.0.2 and rebased the pull requests we intend to include. Please address any conflicts and and squash and merge them into that branch when ready 🥳

@ivadym ivadym mentioned this pull request Jul 21, 2023
10 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f3a6e06) 99.31% compared to head (d48d245) 99.31%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release_12.0.2    #1203   +/-   ##
===============================================
  Coverage           99.31%   99.31%           
===============================================
  Files                  29       29           
  Lines                1756     1756           
===============================================
  Hits                 1744     1744           
  Misses                 12       12           
Flag Coverage Δ
unittests 99.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@khurrammaqbool khurrammaqbool merged commit 6175c55 into release_12.0.2 Jul 21, 2023
@khurrammaqbool khurrammaqbool deleted the fix/add_number_to_tiddit_filter_vcf_header branch July 21, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INFO field in the SV VCF file has the wrong format (TIDDIT filtering)
3 participants