Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: varcall-cnvkit container #1207

Merged
merged 16 commits into from
Jul 21, 2023
Merged

fix: varcall-cnvkit container #1207

merged 16 commits into from
Jul 21, 2023

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Jul 19, 2023 •
edited
Loading

This PR:

Changed:

  • Bump varcall-cnvkit container versions

Review and tests:

  • Tests pass
    Screenshot 2023-07-20 at 14 15 49
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym requested a review from a team July 19, 2023 14:49
@ivadym ivadym changed the base branch from master to fix-cyvcf2-version July 19, 2023 14:49
@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (6461794) 99.31% compared to head (0055db1) 99.31%.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           fix-cyvcf2-version    #1207   +/-   ##
===================================================
  Coverage               99.31%   99.31%           
===================================================
  Files                      29       29           
  Lines                    1756     1756           
===================================================
  Hits                     1744     1744           
  Misses                     12       12
Flag Coverage Δ
unittests 99.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

khurrammaqbool
khurrammaqbool approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@khurrammaqbool khurrammaqbool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from fix-cyvcf2-version to release_12.0.2 July 21, 2023 10:52
@ivadym ivadym merged commit f3a6e06 into release_12.0.2 Jul 21, 2023
@ivadym ivadym deleted the fix-cnvkit-container branch July 21, 2023 10:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Jul 21, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khurrammaqbool khurrammaqbool khurrammaqbool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
BALSAMIC
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivadym @khurrammaqbool