refactor: Remove Balsamic container 👋 👋 #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactor-bind-path-singularity
Co-authored-by: Eva C <29628428+fevac@users.noreply.github.com>
Co-authored-by: Eva C <29628428+fevac@users.noreply.github.com>
…Genomics/BALSAMIC into refactor-bind-path-singularity
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1220 +/- ##
===========================================
- Coverage 99.42% 99.42% -0.01%
===========================================
Files 41 41
Lines 1917 1916 -1
===========================================
- Hits 1906 1905 -1
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
6 tasks
mathiasbio
approved these changes
Aug 9, 2023
Co-authored-by: Mathias Johansson <math.joh.bio@gmail.com>
Co-authored-by: Mathias Johansson <math.joh.bio@gmail.com>
fevac
approved these changes
Aug 9, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
3 tasks
khurrammaqbool
added a commit
that referenced
this pull request
Aug 17, 2023
* refactor: Remove Balsamic container (#1220) * add cadd container * changelog * remove second update command * add cadd to github actions * add tabix to container test * remove tabix from container * remove tabix from container tests * add header * add cadd to cache and tests * refactor docker recipe * refactor download and extract repo --------- Co-authored-by: Vadym <vadym.ivanchuk@scilifelab.se>
khurrammaqbool
added a commit
that referenced
this pull request
Aug 18, 2023
* refactor: Remove Balsamic container (#1220) * add cadd container * changelog * remove second update command * add cadd to github actions * add tabix to container test * remove tabix from container * remove tabix from container tests * add header * add cadd to cache and tests * refactor docker recipe * refactor download and extract repo * add container etiquette * add container etiquette to docs * remove sphinxcontrib-napoleon==0.7 * remove sphinxcontrib * fix deps and URLs * refactor etiquette --------- Co-authored-by: Vadym <vadym.ivanchuk@scilifelab.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
The need for a Balsamic container has become redundant as the original plan to make it functional within the container isn't feasible.
This container also slows the development process, as even small changes in constants require rebuilding it.
Removed:
Review and tests: