-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow custom cache version option for analysis #1244
Conversation
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for most use-cases this doesn't change anything as the cache-version is by default the current balsamic version. But this allows us, in combination with the changes to the init to build a cache with the release-version we intend to use, and then despite not having bumped the version we can choose the later version for the validation. 🤔 sounds really good! I also found no issues with the code except one very very serious one...(just kidding)
Super nice job! 🌟 🧙 🌟
Co-authored-by: Mathias Johansson <math.joh.bio@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR:
Changed:
Review and tests:
balsamic config case --cache-version