Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gatk container #1266

Merged
merged 5 commits into from
Oct 5, 2023
Merged

feat: add gatk container #1266

merged 5 commits into from
Oct 5, 2023

Conversation

khurrammaqbool
Copy link
Collaborator

@khurrammaqbool khurrammaqbool commented Sep 27, 2023 •
edited
Loading

This PR:

Added: gatk container.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@khurrammaqbool khurrammaqbool added this to the Release 13 milestone Sep 27, 2023
@khurrammaqbool khurrammaqbool requested a review from a team as a code owner September 27, 2023 10:45
@khurrammaqbool khurrammaqbool self-assigned this Sep 27, 2023
@khurrammaqbool khurrammaqbool linked an issue Sep 27, 2023 that may be closed by this pull request
[User Story] Fix recurrent problems with BALSAMIC containers #1165
Open
6 tasks
@khurrammaqbool khurrammaqbool mentioned this pull request Sep 27, 2023
Open
6 tasks
@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
BALSAMIC/commands/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/config/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/config/case.py 100.00% <100.00%> (+3.44%) ⬆️
BALSAMIC/commands/config/pon.py 100.00% <100.00%> (+4.87%) ⬆️
BALSAMIC/commands/init/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/options.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/deliver.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/status.py 100.00% <100.00%> (ø)
BALSAMIC/commands/run/analysis.py 100.00% <100.00%> (ø)
... and 18 more

📢 Thoughts on this report? Let us know!.

ivadym
ivadym approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍

@mathiasbio
Copy link
Collaborator

Nice! Thanks so much for adding this! 🔥 🧙 🔥

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khurrammaqbool khurrammaqbool merged commit e788522 into develop Oct 5, 2023
@khurrammaqbool khurrammaqbool deleted the add_gatk_container branch October 5, 2023 07:47
@ivadym ivadym mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivadym ivadym ivadym approved these changes

Assignees

@khurrammaqbool khurrammaqbool

Labels
None yet
Projects
BALSAMIC
Status: Archived
Milestone
Release 13
Development

Successfully merging this pull request may close these issues.

[User Story] Fix recurrent problems with BALSAMIC containers
3 participants
@khurrammaqbool @mathiasbio @ivadym