Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use StrEnum from python enum #1303

Merged
merged 3 commits into from
Oct 27, 2023
Merged

refactor: Use StrEnum from python enum #1303

merged 3 commits into from
Oct 27, 2023

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Oct 27, 2023

This PR:

After upgrading to Python 3.11, we can now use StrEnum directly from the enum module. There's no longer a need to access .value, as we can work with these constants directly.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym requested a review from a team as a code owner October 27, 2023 12:06
@ivadym ivadym self-assigned this Oct 27, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
BALSAMIC/commands/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/config/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/config/case.py 100.00% <100.00%> (+3.44%) ⬆️
BALSAMIC/commands/config/pon.py 100.00% <100.00%> (+4.87%) ⬆️
BALSAMIC/commands/init/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/options.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/deliver.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/status.py 100.00% <100.00%> (ø)
BALSAMIC/commands/run/analysis.py 100.00% <100.00%> (ø)
... and 20 more

📢 Thoughts on this report? Let us know!.

mathiasbio
mathiasbio approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🧙 🔥 I can find nothing wrong with this! I stamp this! ✉️

@ivadym ivadym merged commit f5db948 into develop Oct 27, 2023
9 checks passed
@ivadym ivadym deleted the use-python-strenum branch October 27, 2023 13:34
@ivadym ivadym mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbio mathiasbio mathiasbio approved these changes

Assignees

@ivadym ivadym

Labels
None yet
Projects
BALSAMIC
Status: Archived
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivadym @mathiasbio