fix: add sleep rule before start #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1311 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 39 39
Lines 1974 1975 +1
=======================================
+ Hits 1963 1964 +1
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ivadym
reviewed
Jan 22, 2024
CHANGELOG.rst
Outdated
|
|
||
| Added: | ||
| ^^^^^^ | ||
| * Sleep rule before start to fix key_error https://github.com/Clinical-Genomics/BALSAMIC/pull/1310 |
There was a problem hiding this comment.
Suggested change
| * Sleep rule before start to fix key_error https://github.com/Clinical-Genomics/BALSAMIC/pull/1310 | |
| * Sleep rule before start to fix key_error https://github.com/Clinical-Genomics/BALSAMIC/pull/1311 |
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
BREAK GLASS IN CASE OF KEY_ERROR EMERGENCY
This PR is an ugly solution to the key_error issue (#1300) we sometimes see when a rule finishes before all the jobs have been submitted. It simply adds a 5 minute sleep rule before the actual workflow starts.
If we see this error appearing during verification and validation we can merge this.
After 5 minutes downstream rules begin:
Added:
Tests run:
Review and tests: