Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gens_preprocessing rule missing python directive #1322

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: gens_preprocessing rule missing python directive #1322

merged 1 commit into from
Nov 8, 2023

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Nov 8, 2023

This PR:

Fixes:

/bin/bash: line 1: /home/proj/stage/bin/miniconda3/envs/S_balsamic/lib/python3.11/site-packages/BALSAMIC/assets/scripts/preprocess_gens.py: Permission denied

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym requested a review from a team as a code owner November 8, 2023 09:33
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

mathiasbio
mathiasbio approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Record time! ⭐ 🧙

@ivadym ivadym merged commit 2aa15fa into release_v13.0.0 Nov 8, 2023
6 checks passed
@ivadym ivadym deleted the fix-gens_processing branch November 8, 2023 09:39
@ivadym ivadym mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbio mathiasbio mathiasbio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivadym @mathiasbio