Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add msisensorpro container #1444

Merged
merged 9 commits into from
Jun 14, 2024
Merged

Conversation

khurrammaqbool
Copy link
Collaborator

@khurrammaqbool khurrammaqbool commented Jun 5, 2024

Description

Add MSIsensor-pro container

Added

  • Add MSIsensor-pro container

Documentation

  • N/A
  • Updated Balsamic documentation to reflect the changes as needed for this PR.
    • [Document Name]

Tests

Feature Tests

  • N/A
  • Test [Description]
    • [Screenshot]

Pipeline Integrity Tests

  • Report deliver (generation of the .hk file)
    • N/A
    • Verified
  • TGA T/O Workflow
    • N/A
    • Verified
  • TGA T/N Workflow
    • N/A
    • Verified
  • UMI T/O Workflow
    • N/A
    • Verified
  • UMI T/N Workflow
    • N/A
    • Verified
  • WGS T/O Workflow
    • N/A
    • Verified
  • WGS T/N Workflow
    • N/A
    • Verified
  • QC Workflow
    • N/A
    • Verified
  • PON Workflow
    • N/A
    • Verified

Clinical Genomics Stockholm

Documentation

  • Atlas documentation
    • N/A
    • Updated: [Link]
  • Web portal for Clinical Genomics
    • N/A
    • Updated: [Link]

User Changes

  • N/A
  • This PR affects the output files or results.
    • User feedback is considered unnecessary because [Justification].
    • Affected users have been included in the development process and given a chance to provide feedback.

Infrastructure Changes

  • Stored files in Housekeeper
    • N/A
    • Updated: [Link]
  • CG (CLI and delivered/uploaded files)
    • N/A
    • Updated: [Link]
  • Servers (configuration files on Hasta)
    • N/A
    • Updated: [Link]
  • Scout interface
    • N/A
    • Updated: [Link]

Checklist

Important

Ensure that all checkboxes below are ticked before merging.

For Developers

  • PR Description
    • Provided a comprehensive description of the PR.
    • Linked relevant user stories or issues to the PR.
  • Documentation
    • Verified and updated documentation if necessary.
  • Tests
    • Described and tested the functionality addressed in the PR.
    • Ensured integration of the new code with existing workflows.
    • Confirmed that meaningful unit tests were added for the changes introduced.
    • Checked that the PR has successfully passed all relevant code smells and coverage checks.
  • Review
    • Addressed and resolved all the feedback provided during the code review process.
    • Obtained final approval from designated reviewers.

For Reviewers

  • Code
    • Code implements the intended features or fixes the reported issue.
    • Code follows the project's coding standards and style guide.
  • Documentation
    • Pipeline changes are well-documented in the CHANGELOG and relevant documentation.
  • Tests
    • The author provided a description of their manual testing, including consideration of edge cases and boundary
      conditions where applicable, with satisfactory results.
  • Review
    • Confirmed that the developer has addressed all the comments during the code review.

@khurrammaqbool khurrammaqbool added this to the Release 16 milestone Jun 5, 2024
@khurrammaqbool khurrammaqbool self-assigned this Jun 5, 2024
@khurrammaqbool khurrammaqbool requested a review from a team as a code owner June 5, 2024 09:56
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (828cf3a) to head (7d529e6).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1444   +/-   ##
========================================
  Coverage    99.48%   99.48%           
========================================
  Files           40       40           
  Lines         1930     1932    +2     
========================================
+ Hits          1920     1922    +2     
  Misses          10       10           
Flag Coverage Δ
unittests 99.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khurrammaqbool khurrammaqbool linked an issue Jun 5, 2024 that may be closed by this pull request
3 tasks
@khurrammaqbool khurrammaqbool added the Feature New feature label Jun 5, 2024
CHANGELOG.rst Outdated Show resolved Hide resolved
BALSAMIC/containers/msisensorpro/Dockerfile Outdated Show resolved Hide resolved
BALSAMIC/containers/msisensorpro/Dockerfile Outdated Show resolved Hide resolved
BALSAMIC/containers/msisensorpro/Dockerfile Outdated Show resolved Hide resolved
BALSAMIC/containers/msisensorpro/Dockerfile Show resolved Hide resolved
Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Happy testing! 🌟 Going to be great to have this!

Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💯

For next time, could you please provide a brief explanation if you choose not to address the review comments? Thanks!

BALSAMIC/containers/msisensorpro/Dockerfile Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@khurrammaqbool
Copy link
Collaborator Author

khurrammaqbool commented Jun 13, 2024

Looks good! 💯

For next time, could you please provide a brief explanation if you choose not to address the review comments? Thanks!

Which comment did I not address? I may have missed something. I mean other than -y.

@ivadym
Copy link
Contributor

ivadym commented Jun 13, 2024

Looks good! 💯
For next time, could you please provide a brief explanation if you choose not to address the review comments? Thanks!

Which comment did I not address? I may have missed something. I mean other than -y.

I unresolved the other one, it was just about the chsh command, I'm not sure to which user we'll change the shell if we don't provide it as an argument 🤔

@khurrammaqbool khurrammaqbool merged commit 38770a9 into develop Jun 14, 2024
24 checks passed
@khurrammaqbool khurrammaqbool deleted the feat/add_msisensor_container branch June 14, 2024 07:52
@mathiasbio mathiasbio mentioned this pull request Oct 17, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[User Story] Add MSI analysis
4 participants