Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hgvsg option to VEP #830

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Conversation

hassanfa
Copy link
Contributor

@hassanfa hassanfa commented Dec 6, 2021

This PR:

Added:

  • --hgvsg annotation to VEP

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@hassanfa
Copy link
Contributor Author

hassanfa commented Dec 6, 2021

I noticed hgvsg annotations are missing from BALSAMIC results I received. This fixes that issue. Notice that --everything doesn't add hgvsg.

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #830 (408efd5) into develop (1c3b000) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #830   +/-   ##
========================================
  Coverage    99.61%   99.61%           
========================================
  Files           29       29           
  Lines         1814     1814           
========================================
  Hits          1807     1807           
  Misses           7        7           
Flag Coverage Δ
unittests 99.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
BALSAMIC/constants/workflow_params.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3b000...408efd5. Read the comment docs.

Copy link
Contributor

@ashwini06 ashwini06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, with the update to changelog 👍🏼

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hassanfa hassanfa merged commit d7e68e3 into develop Dec 7, 2021
@hassanfa hassanfa deleted the feat/add_hgvsg_annotation branch December 7, 2021 09:23
@ashwini06 ashwini06 mentioned this pull request Dec 7, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants