Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add SVdb to TGA workflow #879

Merged
merged 3 commits into from
Mar 9, 2022
Merged

feat: add SVdb to TGA workflow #879

merged 3 commits into from
Mar 9, 2022

Conversation

khurrammaqbool
Copy link
Collaborator

This PR:

Added: SVdb merge manta and delly for TGA workflow.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@khurrammaqbool khurrammaqbool self-assigned this Mar 8, 2022
@khurrammaqbool khurrammaqbool linked an issue Mar 8, 2022 that may be closed by this pull request
add SVDB to merge SV and CNV #871
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 8, 2022 •
edited
Loading

Codecov Report

Merging #879 (4a56bac) into develop (1451d11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #879   +/-   ##
========================================
  Coverage    99.60%   99.60%           
========================================
  Files           29       29           
  Lines         1762     1762           
========================================
  Hits          1755     1755           
  Misses           7        7
Flag Coverage Δ
unittests 99.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
BALSAMIC/constants/workflow_params.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1451d11...4a56bac. Read the comment docs.

@khurrammaqbool
Copy link
Collaborator Author

Screenshot 2022-03-08 at 16 01 17

Screenshot 2022-03-08 at 16 00 32

ivadym
ivadym approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ashwini06
ashwini06 approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@ashwini06 ashwini06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@khurrammaqbool khurrammaqbool merged commit e1eeb00 into develop Mar 9, 2022
@khurrammaqbool khurrammaqbool deleted the feat/add_svdb_workflow_tga branch March 9, 2022 13:25
@khurrammaqbool khurrammaqbool changed the title feat: add svdb workflow tga feat: add SVdb to TGA workflow Apr 26, 2022
@khurrammaqbool khurrammaqbool mentioned this pull request Apr 26, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivadym ivadym ivadym approved these changes

@ashwini06 ashwini06 ashwini06 approved these changes

@hassanfa hassanfa Awaiting requested review from hassanfa

Assignees

@khurrammaqbool khurrammaqbool

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add SVDB to merge SV and CNV
3 participants
@khurrammaqbool @ashwini06 @ivadym