Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Option to support new analysis workflows #936

Closed
wants to merge 8 commits into from

Conversation

ashwini06
Copy link
Contributor

@ashwini06 ashwini06 commented May 20, 2022

This PR:

Is the duplicate of where the codecov has issues, as the base branch is corrupted.

  • Adds new analysis_workflow option to balsamic config case to run different workflows (balsamic, balsamic-umi)
  • If --analysis-workflow=balsamic run only balsamic workflow, else if --analysis-workflow=balsamic-umi runs both balsamic+UMI workflow

Test CommandLine

# create config json for balsamic only analysis

balsamic config case  --analysis-workflow balsamic --case-id TN_panel_balsamic --analysis-dir run_tests/ --balsamic-cache /home/proj/stage/cancer/balsamic_cache/ -t tests/test_data/fastq/S1_R_1.fastq.gz -n tests/test_data/fastq/S2_R_1.fastq.gz -p tests/test_data/references/panel/panel.bed

balsamic run analysis -s run_tests/ TN_panel_balsamic/TN_panel_balsamic.json

# create config json for balsamic+UMI  analysis

balsamic config case  --analysis-workflow balsamic-umi --case-id TN_panel_balsamic_umi --analysis-dir run_tests/ --balsamic-cache /home/proj/stage/cancer/balsamic_cache/ -t tests/test_data/fastq/S1_R_1.fastq.gz -n tests/test_data/fastq/S2_R_1.fastq.gz -p tests/test_data/references/panel/panel.bed 

balsamic run analysis -s run_tests/TN_panel_balsamic_umi/TN_panel_balsamic_umi.json

Changed:

  • UMI workflow for panels won't be running with the "balsamic" option
  • New "balsamic-umi" will run both BALSAMIC and UMI workflows.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@ashwini06
Copy link
Contributor Author

balsamic dry-runs

For Tonly_panel (Balsamic_only)

Tonly_panel_balsamic

For Tonly_panel (Balsamic + UMI)

Tonly_panel_balsamic_umi

For TN_panel (Balsamic only)

TNpanel_balsamic

For TN_panel (Balsamic+UMI)

TNpanel_balsamic_umi

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #936 (458b022) into develop (0c6ee47) will decrease coverage by 0.34%.
The diff coverage is 98.94%.

@@             Coverage Diff             @@
##           develop     #936      +/-   ##
===========================================
- Coverage    99.60%   99.25%   -0.35%     
===========================================
  Files           29       29              
  Lines         1761     1756       -5     
===========================================
- Hits          1754     1743      -11     
- Misses           7       13       +6     
Flag Coverage Δ
unittests 99.25% <98.94%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
BALSAMIC/commands/config/pon.py 95.12% <ø> (ø)
BALSAMIC/commands/init/base.py 100.00% <ø> (ø)
BALSAMIC/commands/report/deliver.py 100.00% <ø> (ø)
BALSAMIC/constants/qc_metrics.py 100.00% <ø> (ø)
BALSAMIC/constants/reference.py 100.00% <ø> (ø)
BALSAMIC/constants/variant_filters.py 100.00% <ø> (ø)
BALSAMIC/constants/workflow_params.py 100.00% <ø> (ø)
BALSAMIC/constants/workflow_rules.py 100.00% <ø> (ø)
BALSAMIC/utils/qc_metrics.py 100.00% <ø> (ø)
BALSAMIC/commands/run/analysis.py 99.05% <50.00%> (-0.95%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7ef3d...458b022. Read the comment docs.

@ashwini06 ashwini06 closed this May 20, 2022
@ashwini06 ashwini06 deleted the feat/analysis_workflow_umi branch May 20, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant