Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Disable tnhaplotyper for TN WGS #988

Merged
merged 5 commits into from
Aug 30, 2022
Merged

refactor: Disable tnhaplotyper for TN WGS #988

merged 5 commits into from
Aug 30, 2022

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Aug 29, 2022

This PR:

Removed:

  • TNhaplotyper for paired WGS analysis

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym changed the title Disable tnhaplotyper for TN WGS refactor: Disable tnhaplotyper for TN WGS Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022 •
edited
Loading

Codecov Report

Base: 99.24% // Head: 99.24% // No change to project coverage 👍

Coverage data is based on head (c2ef592) compared to base (4406f63).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #988   +/-   ##
========================================
  Coverage    99.24%   99.24%           
========================================
  Files           29       29           
  Lines         1722     1722           
========================================
  Hits          1709     1709           
  Misses          13       13
Flag Coverage Δ
unittests 99.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ivadym ivadym marked this pull request as ready for review August 29, 2022 09:42
@ivadym ivadym linked an issue Aug 29, 2022 that may be closed by this pull request
Disable TNhaplotyper for WGS tumor-normal #981
Closed
@ivadym ivadym mentioned this pull request Aug 29, 2022
Closed
60 tasks
@ivadym
Copy link
Contributor Author

ivadym commented Aug 29, 2022

MASTER BRANCH output for a WGS TN analysis:

Screen Shot 2022-08-29 at 11 31 00

After removing TNhaplotyper:

Screen Shot 2022-08-29 at 17 05 26

khurrammaqbool
khurrammaqbool approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@khurrammaqbool khurrammaqbool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great job!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ivadym ivadym merged commit 818ad03 into develop Aug 30, 2022
@ivadym ivadym deleted the disable-tnhaplotyper branch August 30, 2022 13:34
@ivadym ivadym mentioned this pull request Aug 30, 2022
Closed
@khurrammaqbool khurrammaqbool mentioned this pull request Dec 5, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khurrammaqbool khurrammaqbool khurrammaqbool approved these changes

@hassanfa hassanfa Awaiting requested review from hassanfa

@ashwini06 ashwini06 Awaiting requested review from ashwini06

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable TNhaplotyper for WGS tumor-normal
2 participants
@ivadym @khurrammaqbool